Improve fine-tuning CLI messages with rich #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/together/cli/api/finetune.py
Outdated
| from textwrap import wrap | ||
|
|
||
| import click | ||
| from click.core import ParameterSource # type: ignore[attr-defined] | ||
| from rich import print as rich_print |
There was a problem hiding this comment.
in one place you import as rich_print, in other as just print
let's import always as "print"? I believe it's 1to1 replacement for print so should be fine
There was a problem hiding this comment.
I'm not a big fan of replacing builtins, as it makes understanding the code more difficult (you don't know which function is called). Rich suggests in their docs to use rprint, so I will switch to that
thepowerfuldeez
approved these changes
Sep 24, 2024
azahed98
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users submit a command to fine-tune a model at the moment, the report message prints out the entire response to the fine-tuning request, which contains a lot of technical information and is difficult to understand. This PR replaces that with logging of
FinetuneRequestinstead before the job is submitted and prints the identifier of the job along with its time when the job is accepted by the API.The difference is easiest to see in screenshots.
Before:
After:
Fixes ENG-7292