Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tag to <section>...</section> #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change tag to <section>...</section> #3

wants to merge 2 commits into from

Conversation

serjan-nasredin
Copy link

It seemed strange to me that there is a nav tag in the footer tag.

@floitsch floitsch requested a review from enyo December 17, 2021 17:33
@enyo
Copy link
Contributor

enyo commented Jan 5, 2022

Hey @snxx-lppxx thx for the PR. Although a <nav> is perfectly fine inside a <footer> it's true that it's probably overly verbose (and mozilla actually lists this as an example where a <nav> is not necessary). But I'm not too happy having the <section> in there either since it's already in a <footer> element which is redundant. If you change the <section> to a <div class="footer"> I'd be happy to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enyo enyo Awaiting requested review from enyo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serjan-nasredin @enyo