Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if watchdogs are closed before operating on them #12

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Check if watchdogs are closed before operating on them #12

merged 3 commits into from
Jan 14, 2025

Conversation

kasperl
Copy link
Contributor

@kasperl kasperl commented Jan 14, 2025

No description provided.

@kasperl kasperl requested a review from floitsch January 14, 2025 10:24
@kasperl
Copy link
Contributor Author

kasperl commented Jan 14, 2025

Before this change, calling methods on a closed Watchdog would also throw, but it would be a hard-to-grok type error from trying to return null from handle_, which is supposed to return an int.

floitsch
floitsch approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

floitsch
floitsch approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Still LGTM.

floitsch
floitsch approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@kasperl kasperl merged commit 2621b25 into main Jan 14, 2025
8 checks passed
@kasperl kasperl deleted the check-closed branch January 14, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperl @floitsch