Add hardware-watchdog abstraction. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a feature that was introduced in a later SDK version.
kasperl
reviewed
Feb 9, 2024
src/provider.toit
Outdated
| import log | ||
| import monitor | ||
| import system.services show ServiceProvider ServiceResource ServiceHandler | ||
| import .api.service | ||
| import .esp32 show HardwareWatchdogEsp32 | ||
|
|
||
| interface HardwareWatchdog: |
There was a problem hiding this comment.
I'm not sure hardware is a great name here given that this can be mocked, etc.
There was a problem hiding this comment.
Renamed back to "system" (SystemWatchdog)
kasperl
approved these changes
Feb 10, 2024
Co-authored-by: Kasper Lund <[email protected]>
Fix last reference.
|
Thanks. one reference to "hardware" was left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.