Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Added shortcuts #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Added shortcuts #12

wants to merge 1 commit into from

Conversation

dragonito
Copy link
Contributor

No description provided.

@dragonito
Copy link
Contributor Author

fixes #11

tolry
tolry requested changes Jul 14, 2017
View reviewed changes
Copy link
Owner

@tolry tolry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tell a bit about this PR? Why two different types of shortcuts? What do they do exactly? Why those key combinations?

src/background.js
});

chrome.commands.onCommand.addListener(function(command) {
console.log('Command:', command);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still WIP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, github != gitlab sorry

src/manifest.json
"default": "Ctrl+Shift+X",
"mac": "Command+Shift+X"
},
"description": "Adding mental notes bookmark",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Adding MentalNote bookmark"

@dragonito dragonito changed the title Added shortcuts WIP: Added shortcuts Jul 14, 2017
@dragonito
Copy link
Contributor Author

I have not found a good shortcut yet.
Depending on the system you can put others.
In the Mac bspw you like to take the CMD Button (Apple Button)

(Google Translate) bg

@tolry
Copy link
Owner

tolry commented Jan 5, 2018 •
edited
Loading

@dragonito would you mind rebasing this or can we scrap it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolry tolry tolry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonito @tolry