Add haversine distance metric #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ---- - This adds support for `haversine` distance metric - Fix CI to point to correct branch
tom-whitehead
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
Looks good thanks for this. I guess it's not ideal that we're hard coding the radius as in theory people might want to be clustering on different size spheres, but there isn't much flexibility in how I implemented it.
If I can ever make the time I plan to do a major version bump down the line and clean up the API to allow people to implement their own distance metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
haversinedistance metric