Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: Legacy style transforms #1639

Merged
merged 15 commits into from
Jan 14, 2025
Merged

Improve: Legacy style transforms #1639

merged 15 commits into from
Jan 14, 2025

Conversation

tomusborne
Copy link
Owner

This PR improves block transforms from v1 to v2. It will now transform legacy effects to the new styles object.

@tomusborne tomusborne added the refactoring Refactoring, minor code changes label Jan 10, 2025
@tomusborne tomusborne added this to the 2.0.0 milestone Jan 10, 2025
iansvo
iansvo reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@iansvo iansvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a pass through the code, it seems in order, i'll need to do some more thorough testing in browser to confirm.

Would it be feasible to get unit tests for this? It seems like the kind of thing that should be testable and valuable to test if we can.

@tomusborne
Feature: Legacy Grid block transform
36385eb
@tomusborne
Add common 2 column grids
690abda
@tomusborne
Merge branch 'release/2.0.0' into improve/legacy-style-transforms
8dc2780
@tomusborne
Merge branch 'improve/legacy-style-transforms' into feature/grid-bloc…
cf7d0ed 
…k-transform
@tomusborne
Merge branch 'release/2.0.0' into improve/legacy-style-transforms
7e8858e
@tomusborne
Merge branch 'improve/legacy-style-transforms' into feature/grid-bloc…
5e2396a 
…k-transform
@tomusborne
Fix: Migration of global max width
4dbeda7
@tomusborne
Add logic for 33% grid items
4dd99f3
@tomusborne
Disable transforms on Query Loop grids
43b37a3
@tomusborne
Merge branch 'improve/legacy-style-transforms' into feature/grid-bloc…
e71001c 
…k-transform
@tomusborne
Merge branch 'release/2.0.0' into improve/legacy-style-transforms
98c5fb1
@tomusborne
Merge branch 'improve/legacy-style-transforms' into feature/grid-bloc…
5431d6e 
…k-transform
@tomusborne
Merge pull request #1641 from tomusborne/feature/grid-block-transform
0f4446b 
Feature: Legacy Grid block transform
@tomusborne
Fix: Missing z-index transform
a521e19
@tomusborne tomusborne merged commit ea7ec4f into release/2.0.0 Jan 14, 2025
9 checks passed
@tomusborne tomusborne deleted the improve/legacy-style-transforms branch January 14, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansvo iansvo iansvo left review comments

Assignees
No one assigned
Labels
refactoring Refactoring, minor code changes
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tomusborne @iansvo