Patch invlid return types in api definition

tong · Jun 15, 2023 · 3f70ec2 · 3f70ec2
1 parent b12599c
commit 3f70ec2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/electron-api.json b/electron-api.json
@@ -8620,10 +8620,7 @@
             "returns": null
           }
         ],
-        "returns": {
-          "collection": false,
-          "type": "this"
-        },
+        "returns": null,
         "additionalTags": [],
         "urlFragment": "#requestendchunk-encoding-callback"
       },
@@ -15845,7 +15842,7 @@
             "description": "",
             "required": false,
             "collection": false,
-            "type": "RequestInit & { bypassCustomProtocolHandlers?: boolean }"
+            "type": "RequestInit"
           }
         ],
         "returns": {
@@ -42204,4 +42201,4 @@
       }
     ]
   }
-]
+]
diff --git a/src/electron/main/ClientRequest.hx b/src/electron/main/ClientRequest.hx
@@ -108,7 +108,7 @@ package electron.main;
 	/**
 		Sends the last chunk of the request data. Subsequent write or end operations will not be allowed. The `finish` event is emitted just after the end operation.
 	**/
-	function end(?chunk:haxe.extern.EitherType<String, js.node.Buffer>, ?encoding:String, ?callback:haxe.Constraints.Function):ClientRequest;
+	function end(?chunk:haxe.extern.EitherType<String, js.node.Buffer>, ?encoding:String, ?callback:haxe.Constraints.Function):Void;
 	/**
 		Cancels an ongoing HTTP transaction. If the request has already emitted the `close` event, the abort operation will have no effect. Otherwise an ongoing event will emit `abort` and `close` events. Additionally, if there is an ongoing response object,it will emit the `aborted` event.
 	**/

diff --git a/src/electron/remote/ClientRequest.hx b/src/electron/remote/ClientRequest.hx
@@ -108,7 +108,7 @@ package electron.remote;
 	/**
 		Sends the last chunk of the request data. Subsequent write or end operations will not be allowed. The `finish` event is emitted just after the end operation.
 	**/
-	function end(?chunk:haxe.extern.EitherType<String, js.node.Buffer>, ?encoding:String, ?callback:haxe.Constraints.Function):ClientRequest;
+	function end(?chunk:haxe.extern.EitherType<String, js.node.Buffer>, ?encoding:String, ?callback:haxe.Constraints.Function):Void;
 	/**
 		Cancels an ongoing HTTP transaction. If the request has already emitted the `close` event, the abort operation will have no effect. Otherwise an ongoing event will emit `abort` and `close` events. Additionally, if there is an ongoing response object,it will emit the `aborted` event.
 	**/