Latest version #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added originalIndex property
Scroll while dragging implementation
Fix typo
added direction (left|right) on swipe event detail
Now the regexp catches only Chrome/34, if you use [34] the regexp actually matches any number between 3 and 4, for instance Chrome/35 or Chrome/40 are matching the expression.
Fix Chrome Version RegExp
It shouldn’t be necessary…
This reverts commit 4742624. Unfortunately, still seeing z-index problems in 37.0.2028.0 canary
Add slip:cancelswipe event
Previously, when handling 'beforewait' to allow for 'instant' drag mode by using event.preventDefault() the dragged item would go into reorder mode without firing the 'beforereorder' event. This prevented the use case of combining the 'instant' drag mode with handling 'beforereorder' to prevent dragging of non-draggable items.
Fire beforereorder even when using 'instant' drag mode.
add originalIndex to swipe's event.detail
Add example from https://kornel.ski/slip/
Scroll example
Prevent scrolling beyond the maximum height
Detach leaves ariaRoles and tabIndex. Remove them so slip don't left traces behind
adding and removing from classList instead of manually editing class
Use exact match on classList instead of regex on className to test CSS classes
prevent event bubbling to support nested lists
* Add option to ignore elements Added a non-breaking mechanics for detecting if user specified elements to ignore and getting a filtered list of nodes if necessary, otherwise resorting to old method. Related #101
Also allow scrollContainer to be explicitly set via an option
Fix scrolling, to use document.scrollingElement instead of document.body
…t passed in the slip constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.