Build the docker and push #33
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,18 @@ | ||
| OPENAI_API_KEY=sk | ||
| WEAVIATE_URL = | ||
| WEAVIATE_API_KEY = | ||
| ENV = docker | ||
| POSTGRES_USER = bla | ||
| POSTGRES_PASSWORD = bla | ||
| POSTGRES_DB = bubu | ||
| POSTGRES_HOST = localhost | ||
| POSTGRES_HOST_DOCKER = postgres | ||
| SEGMENT_KEY = Etl4WJwzOkeDPAjaOXOMgyU16hO7mV7B | ||
| COG_ARCH_DIR = cognitive_architecture | ||
| GRAPH_DB_URL = | ||
| GRAPH_DB_PW = | ||
| GRAPH_DB_USER = | ||
| AWS_ACCESS_KEY_ID = | ||
| AWS_SECRET_ACCESS_KEY = | ||
| QDRANT_API_KEY | ||
| QDRANT_API_URL | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,38 +23,38 @@ jobs: | |
| steps: | ||
| - name: Take code from repo | ||
| uses: actions/checkout@v3 | ||
| - name: Set environment variable for stage | ||
| id: set-env | ||
| run: | | ||
| if [[ "${{ github.ref }}" == "refs/heads/main" ]]; then | ||
| echo "STAGE=prd" >> $GITHUB_ENV | ||
| echo "::set-output name=stage::prd" | ||
| else | ||
| echo "STAGE=dev" >> $GITHUB_ENV | ||
| echo "::set-output name=stage::dev" | ||
| fi | ||
| - name: Use output | ||
| run: echo "The stage is ${{ steps.set-env.outputs.stage }}" | ||
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v1 | ||
| with: | ||
| role-to-assume: ${{ env.AWS_ROLE_DEV_CICD }} | ||
| aws-region: eu-west-1 | ||
| - name: Create Docker image and push to ECR | ||
| uses: ./.github/actions/image_builder | ||
| id: generate-promethai-docker | ||
| with: | ||
| stage: prd | ||
| aws_account_id: ${{ env.AWS_ACCOUNT_ID_DEV }} | ||
| should_publish: true | ||
| ecr_image_repo_name: promethai-prd-backend-promethai-backend | ||
| dockerfile_location: ./ | ||
| - name: Export Docker image tag | ||
| id: export-promethai-docker-tag | ||
| run: | | ||
| export DOCKER_TAG=$(cat /tmp/.DOCKER_IMAGE_VERSION) | ||
| echo "Docker tag is: $DOCKER_TAG" | ||
| echo "promethai_docker_tag_backend=$DOCKER_TAG" >> $GITHUB_OUTPUT | ||
|
|
||
| # - name: Create Tag and Release | ||
| # runs-on: ubuntu-latest | ||
|
|
@@ -78,22 +78,22 @@ jobs: | |
| # with: | ||
| # tag_name: ${{ steps.bump_version_and_push_tag.outputs.tag }} | ||
| # release_name: Release ${{ steps.bump_version_and_push_tag.outputs.tag }} | ||
| outputs: | ||
| promethai_docker_tag_backend: ${{ steps.export-promethai-docker-tag.outputs.promethai_docker_tag_backend }} | ||
|
|
||
| apply_tf: | ||
| name: Trigger terraform apply workflow | ||
| runs-on: ubuntu-latest | ||
| needs: publish_docker_to_ecr | ||
| steps: | ||
| - name: TF apply workflow triggers step | ||
| uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.PAT_FOR_CROSS_REPOS_CICD_TRIGGERING }} | ||
| script: | | ||
| await github.rest.actions.createWorkflowDispatch({ | ||
| owner: 'topoteretes', | ||
| repo: 'PromethAI-Infra', | ||
| workflow_id: 'terraform.apply.yml', | ||
| ref: 'main' | ||
| }) | ||
|
Comment on lines
78
to
+99
There was a problem hiding this comment.
The commented-out code for creating tags and releases is still present in the workflow file. If these steps have been implemented elsewhere, this commented-out code should be removed to avoid confusion and maintain cleanliness of the workflow file. - # - name: Create Tag and Release
- # runs-on: ubuntu-latest
- # uses: actions/checkout@v3
- # needs: publish_docker_to_ecr # ensure this job runs after Docker image is pushed
- # steps:
- # - name: Check out code
- # uses: actions/checkout@v3
- # - name: Bump version and push tag
- # id: bump_version_and_push_tag
- # uses: anothrNick/[email protected]
- # env:
- # GITHUB_TOKEN: ${{ secrets.PAT_FOR_CROSS_REPOS_CICD_TRIGGERING }}
- # WITH_V: true
- # DEFAULT_BUMP: 'minor' # or 'minor' or 'major'
- # - name: Create Release
- # id: create_release
- # uses: actions/create-release@v1
- # env:
- # GITHUB_TOKEN: ${{ secrets.PAT_FOR_CROSS_REPOS_CICD_TRIGGERING }}
- # with:
- # tag_name: ${{ steps.bump_version_and_push_tag.outputs.tag }}
- # release_name: Release ${{ steps.bump_version_and_push_tag.outputs.tag }} |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The search results indicate that the
ENVIRONMENTvariable is still being used in several places within the codebase:entrypoint.shREADME.md(twice, in instructions)iterations/level_3/create_database.pyiterations/level_3/entrypoint.shiterations/level_3/database/database.pyiterations/level_2/entrypoint.shGiven this information, the renaming of
ENVIRONMENTtoENVin the.env.templatefile is not consistently applied across the entire project. The references toENVIRONMENTin theREADME.mdare likely instructional and may need to be updated to reflect the changes in the.env.templatefile. The occurrences in the scripts and Python files suggest that the code still expects anENVIRONMENTvariable to be set.Based on these findings, the following issues have been identified:
ENVIRONMENTvariable is still being used in multiple places, which could lead to inconsistencies or errors if the environment variable is expected to beENVnow.README.mdfile contains outdated instructions regarding theENVIRONMENTvariable.Analysis chain
Ensure that the new AWS and QDRANT API keys are handled securely and are not exposed in the codebase or version control. Verify that the renaming of
ENVIRONMENTtoENVis consistently applied across the entire project.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 55
Script:
Length of output: 495