Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5479 - GUIDE, EDITORIAL, EVENT TEMPLATES | Add extra required fields #1068

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

patrickcuagan
Copy link
Collaborator

Ticket: https://torchbox.monday.com/boards/1472452416/pulses/1605295479

This MR makes the three fields required:

  1. Social networks (image)
  2. Social text
  3. Listing information image

rca/utils/models.py Outdated Show resolved Hide resolved
@kevinhowbrook kevinhowbrook self-requested a review January 16, 2025 09:11
Copy link
Collaborator

@kevinhowbrook kevinhowbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickcuagan - Think the tests might need updating (CI failures) now given the required images

@patrickcuagan patrickcuagan force-pushed the updates/5479-making-extra-fields-required branch from bf98809 to 2219748 Compare January 17, 2025 01:30
@patrickcuagan
Copy link
Collaborator Author

Thanks @patrickcuagan - Think the tests might need updating (CI failures) now given the required images

I've updated this to make it required via the form instead. I just remembered we briefly talked about this during refinement one time. This way - we don't have to update all the factories etc.

@kevinhowbrook kevinhowbrook self-requested a review January 17, 2025 09:35
@patrickcuagan patrickcuagan merged commit 2d8f478 into master Jan 20, 2025
6 checks passed
@patrickcuagan patrickcuagan deleted the updates/5479-making-extra-fields-required branch January 20, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants