-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1301 - PROGRAMME FINDER | MRes Healthcare & Design and MRes RCA #1069
Conversation
…rom previous field
…ature/1301-multiple-program-types
@@ -20,6 +20,7 @@ class PagesAPIViewSet(views.PagesAPIViewSet): | |||
DescendantOfFilter, | |||
filters.RelatedSchoolsFilter, | |||
filters.SubjectsFilter, | |||
filters.ProgrammeTypesFilter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now a many to many field so we've had to add this additional filter.
eead2ae
to
52baff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @patrickcuagan - This looks good to me.
I just want to point out, as I'm sure you are aware, that the enquire to study form has integrations with Mailchimp and QS... so when testing on dev (if possible still) we need to make sure the integration still accepts the data; although it doesn't look like the shape of data we send has changed. Just thinking if we send through program types, and that's now multiple it may need to be updated.
Yeah that was one of my concerns as well. For enquire to study forms, we use programme pages instead of the programme type. In programme pages, we we have a |
Ticket: https://torchbox.monday.com/boards/1472452416/pulses/1605295479
This MR allows editors to add more than one programme_type for program and short course pages. This means that a program/short course can show in multiple program types when searching through the program finder.