Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 63 compatibility #35

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Jan 3, 2025

This pull request introduces changes to support new versions of Python and Wagtail in the project.

Support for new Python and Wagtail versions:

  • .github/workflows/test.yml: Added Python 3.13 to the matrix of Python versions for testing.
  • tox.ini: Added Python 3.13 and Wagtail 6.2, 6.3 to the testing environments. Included dependencies for Django 5.1 and Wagtail 6.2, 6.3. [1] [2]

Conditional imports for Wagtail versions:

@ababic
Copy link
Collaborator

ababic commented Jan 7, 2025

Thanks for this @nickmoreton. The coverage job failure should have been addressed in main now, so this should be good after a rebase :)

@nickmoreton nickmoreton force-pushed the wagtail-63-compatibility branch from 0bdb5e8 to 0a68e75 Compare January 7, 2025 21:23
@nickmoreton nickmoreton marked this pull request as ready for review January 13, 2025 12:56
@nickmoreton
Copy link
Contributor Author

Thanks for this @nickmoreton. The coverage job failure should have been addressed in main now, so this should be good after a rebase :)

Hi @ababic I think this is ready to go now.

Copy link
Collaborator

@ababic ababic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again @nickmoreton!

@ababic ababic merged commit f7dd08f into torchbox:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants