Use SnippetViewSet instead & delete superfluous 'usage' code

tbx/taxonomy/admin.py

@@ -1,151 +1,18 @@
-from django.contrib.admin.utils import quote
-from django.core.exceptions import PermissionDenied
-from django.urls import re_path
-from django.utils.functional import cached_property
-from django.utils.translation import gettext as _
-
-from wagtail_modeladmin.helpers import ButtonHelper
-from wagtail_modeladmin.options import ModelAdmin, ModelAdminGroup
-from wagtail_modeladmin.views import DeleteView, InstanceSpecificView
+from wagtail.snippets.views.snippets import SnippetViewSet, SnippetViewSetGroup
 
 from . import models
-from .utils import get_object_usage
-
-
-class UsageView(InstanceSpecificView):
-    page_title = _("Usage of")
-
-    def get_usage(self):
-        return get_object_usage(self.instance)
-
-    def check_action_permitted(self, user):
-        return self.permission_helper.user_can_edit_obj(user, self.instance)
-
-    def get_meta_title(self):
-        return _("Usage of %s") % self.verbose_name
-
-    def get_context_data(self, **kwargs):
-        context = super(UsageView, self).get_context_data(**kwargs)
-        context.update(
-            {"view": self, "instance": self.instance, "usage": self.get_usage()}
-        )
-        return context
-
-    def get_template_names(self):
-        return ["taxonomy/admin/usage.html"]
-
-
-class TaxonomyDeleteView(DeleteView):
-    """
-    A specialised delete view which protects taxonomy objects that are
-    in use on the site
-    """
-
-    @cached_property
-    def usage_url(self):
-        return self.url_helper.get_action_url("usage", self.pk_quoted)
-
-    def get_usage(self):
-        return get_object_usage(self.instance)
-
-    def post(self, request, *args, **kwargs):
-        # Disallow deleting taxonomy objects that are in use
-        if self.get_usage().exists():
-            raise PermissionDenied
-
-        return super(TaxonomyDeleteView, self).post(request, *args, **kwargs)
-
-    # Wagtail doesn't yet call get_context_data on DeleteView so we override get() for now
-
-    # def get_context_data(self, **kwargs):
-    #     context = super(TaxonomyDeleteView, self).get_context_data(**kwargs)
-    #     import pdb; pdb.set_trace()
-    #     context['can_be_deleted'] = not self.get_usage().exists()
-    #     return context
 
-    def get(self, request, *args, **kwargs):
-        context = {
-            "view": self,
-            "instance": self.instance,
-            "can_be_deleted": not self.get_usage().exists(),
-        }
-
-        return self.render_to_response(context)
-
-    def get_template_names(self):
-        return ["taxonomy/admin/delete.html"]
-
-
-class TaxonomyButtonHelper(ButtonHelper):
-    """
-    A subclass of ButoonHelper which includes a 'Usage' button
-    """
-
-    usage_button_classnames = []
-
-    def usage_button(self, pk, classnames_add=[], classnames_exclude=[]):
-        classnames = self.usage_button_classnames + classnames_add
-        cn = self.finalise_classname(classnames, classnames_exclude)
-        return {
-            "url": self.url_helper.get_action_url("usage", quote(pk)),
-            "label": _("Usage"),
-            "classname": cn,
-            "title": _("Usage of %s") % self.verbose_name,
-        }
-
-    def get_buttons_for_obj(
-        self, obj, exclude=None, classnames_add=None, classnames_exclude=None
-    ):
-        exclude = exclude or []
-        classnames_add = classnames_add or []
-        classnames_exclude = classnames_exclude or []
-
-        btns = super(TaxonomyButtonHelper, self).get_buttons_for_obj(
-            obj,
-            exclude=exclude,
-            classnames_add=classnames_add,
-            classnames_exclude=classnames_exclude,
-        )
-
-        ph = self.permission_helper
-        usr = self.request.user
-        pk = quote(getattr(obj, self.opts.pk.attname))
-
-        if "usage" not in exclude and ph.user_can_edit_obj(usr, obj):
-            btns.append(self.usage_button(pk, classnames_add, classnames_exclude))
-
-        return btns
-
-
-class TaxonomyModelAdmin(ModelAdmin):
-    button_helper_class = TaxonomyButtonHelper
-    usage_view_class = UsageView
-    delete_view_class = TaxonomyDeleteView
-
-    def usage_view(self, request, instance_pk):
-        kwargs = {"model_admin": self, "instance_pk": instance_pk}
-        view_class = self.usage_view_class
-        return view_class.as_view(**kwargs)(request)
 
+class TaxonomyModelAdmin(SnippetViewSet):
     def get_admin_urls_for_registration(self):
-        urls = super(TaxonomyModelAdmin, self).get_admin_urls_for_registration()
-
-        urls += (
-            re_path(
-                self.url_helper.get_action_url_pattern("usage"),
-                self.usage_view,
-                name=self.url_helper.get_action_url_name("usage"),
-            ),
-        )
-
-        return urls
+        return super().get_admin_urls_for_registration()
 
 
 class ServiceModelAdmin(TaxonomyModelAdmin):
     model = models.Service
 
 
-class TaxonomyModelAdminGroup(ModelAdminGroup):
+class TaxonomyModelAdminGroup(SnippetViewSetGroup):
     menu_label = "Taxonomy"
     menu_icon = "folder-open-inverse"
     menu_order = 750

tbx/taxonomy/wagtail_hooks.py

@@ -1,5 +1,5 @@
-from wagtail_modeladmin.options import modeladmin_register
+from wagtail.snippets.models import register_snippet
 
 from .admin import TaxonomyModelAdminGroup
 
-modeladmin_register(TaxonomyModelAdminGroup)
+register_snippet(TaxonomyModelAdminGroup)