CR/a11y fixes

torchbox · Jan 4, 2024 · 96e7386 · 96e7386
1 parent 686e394
commit 96e7386
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/...ject_styleguide/templates/patterns/molecules/streamfield/blocks/course_outline_block.html b/...ject_styleguide/templates/patterns/molecules/streamfield/blocks/course_outline_block.html
@@ -8,11 +8,13 @@ <h2 class="course-outline__heading">{{ value.heading }}</h2>
     <ol class="course-outline__list">
         {% for block in value.course_outline %}
             <li class="course-outline__list-item">
-                <svg class="course-outline__icon">
+                <svg class="course-outline__icon" aria-hidden="true">
                     <use xlink:href="#star" />
                 </svg>
                 <div>
-                    <h3 class="course-outline__sub-heading">{{ forloop.counter }}. {{ block.title }}</h3>
+                    <h3 class="course-outline__sub-heading" aria-label="{{ block.title }}">
+                        {{ forloop.counter }}. {{ block.title }}
+                    </h3>
                     {{ block.text|richtext }}
                 </div>
             </li>

diff --git a/...t_styleguide/templates/patterns/molecules/streamfield/blocks/external_link_cta_block.html b/...t_styleguide/templates/patterns/molecules/streamfield/blocks/external_link_cta_block.html
@@ -1,5 +1,5 @@
 <div class="external-link-cta-wrapper">
-    <a class="external-link-cta" href="{{ value.link}}">
+    <a class="external-link-cta" href="{{ value.link }}">
         <div class="external-link-cta__overflow-hider">
             <div class="external-link-cta__swish-background"></div>
         </div>

diff --git a/tbx/project_styleguide/templates/patterns/pages/courses/course_detail_page.html b/tbx/project_styleguide/templates/patterns/pages/courses/course_detail_page.html
@@ -9,7 +9,7 @@ <h1 class="title-block__heading title-block__heading--course">
                 {{ page.strapline|richtext }}
             </h1>
             <div class="title-block__course-detail">
-                {% if page.sessions or page.cost %}
+                {% if page.sessions %}
                     <p class="title-block__sessions">
                         {{ page.sessions }}
                         {% if page.cost and page.sessions %} <span aria-hidden="true"></span> {% endif %} {{ page.cost }}