Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Remove 'heading for processes' field on processes block #552

Merged

Conversation

helenb
Copy link
Member

@helenb helenb commented Nov 7, 2023

Link to Ticket

Description of Changes Made

Simply removes the field (which is not displayed anywhere in the front-end) and creates a migration to delete the content.
This is based off #549 to avoid any migration clashes, so that will need to be deployed first, or they can be deployed together.

How to Test

Edit a sub-proposition page, add a process block, and ensure you can't see a field called 'Heading for processes'.

Screenshots

Expand to see more

Before:

Screenshot 2023-11-07 at 12 12 28

After:
Screenshot 2023-11-07 at 12 12 39

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@helenb helenb requested a review from engineervix November 7, 2023 12:14
Copy link
Member

@engineervix engineervix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @helenb

@helenb helenb merged commit e4f78c8 into process-block-cleanup Nov 9, 2023
2 checks passed
@helenb helenb deleted the feature/remove-unused-process-block-header branch November 9, 2023 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants