-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lparsons396 Thank for doing this. There's a few dependencies that could do with been bumped to latest releases before is merged.
8f14b41
to
904b607
Compare
.github/workflows/test.yml
Outdated
@@ -16,7 +16,7 @@ jobs: | |||
|
|||
services: | |||
postgres: | |||
image: postgres:9.6 | |||
image: postgres:12.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's match this with the production version (which is 13.12
at the moment).
pyproject.toml
Outdated
Django = "~3.2.20" | ||
wagtail = "~5.0" | ||
python = "^3.11" | ||
Django = "4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django = "4.2" | |
Django = "~4.2" |
as = "4.2"
literally asks for version 4.2, not 4.2.x
Thanks for your review @zerolab , let me know if there's anything else! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0aa3fe3
to
c03020a
Compare
@helenb imho this is ready to go too |
From @katdom13 on slack: "I’m also encountering this error during staging deployment for 5.2: I will also need to wait to hear if 5.2 has been tested on staging. |
|
tbx/urls.py
Outdated
Page.serve = method_decorator(get_default_cache_control_decorator(), name="serve")( | ||
Page.serve | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @helenb , |
921ffad
to
bf06055
Compare
4f62ccb
to
438afdc
Compare
438afdc
to
66c5c9f
Compare
Hi @zerolab ,
I saw this just now and updated the fix accordingly. Could you please review the changes starting at: Thanks! |
@katdom13 I've created this ticket for Anna to test this on staging so we can be clear when this is ready to be merged: https://torchbox.monday.com/boards/1192293412/pulses/1347671612 |
This PR upgrades Wagtail to version 5.2
See Monday ticket & Wagtail 5.2 release notes.
This branch builds on the Wagtail 5.1 upgrade #544
The upgrade considerations actualise many of the deprecation warnings is the 5.1 upgrade and so few changes have been necessary here. Upgrading Wagtail has also necessitated the upgrading of django-filter (22.1 -> 23.4) and django-modelcluster (6.0 -> 6.1). All packages have been checked against the package board and use the appropriate tag / branch as needed.