Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Add course pages FE #563

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Add course pages FE #563

merged 5 commits into from
Jan 4, 2024

Conversation

siimonevans
Copy link
Member

@siimonevans siimonevans commented Jan 3, 2024

⚠️ Based on #562

Description of Changes Made

This PR builds on Kev's BE work, adding FE for the course landing/detail pages.

No tickets for this feature.

Designs here - note we've deviated in some places in order to re-use existing styles, e.g 'What you’ll learn' section.

How to Test

See #562 for instructions on which pages to add and further detail. To review, the reviewer will need to manually create and populate these pages in Wagtail - we're not bothering with PL data given its existing state.

In one or two places I've had to override existing CSS specificity, or pulled in code from the Careers site - it wasn't deemed worth the effort to bring these up to scratch for this codebase given the imminent redesign project.

Screenshots

localhost_3001_course-landing-page_ (1)
localhost_3001_course-landing-page_
localhost_3001_course-landing-page_course-1-django-developer-fundamentals_ (1)
localhost_3001_course-landing-page_course-1-django-developer-fundamentals_

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@siimonevans siimonevans self-assigned this Jan 3, 2024
Copy link
Contributor

@William-Blackie William-Blackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Simon, looks good! Mostly nitpicks.

@siimonevans siimonevans merged commit da28a9a into course-landing-page Jan 4, 2024
3 checks passed
@siimonevans siimonevans deleted the course-pages-fe branch January 4, 2024 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants