Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Update password required page styles #566

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

jhancock532
Copy link
Contributor

Description of Changes Made

Added basic styles to the password required page.

How to Test

In Wagtail admin, click on the status tag for a page (the info icon in the top right of the editor menu) and set the page to private, accessible by password. Then try viewing the page.

Note that this page style works best for the normal color scheme, when locking pages that use dark mode the logo and navigation menu are hidden. This template didn't support dark mode by default, this can be fixed in future work.

Screenshots

Expand to see more Screenshot 2024-02-21 at 14 12 19 Screenshot 2024-02-21 at 14 09 45

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@jhancock532 jhancock532 requested a review from kbayliss February 21, 2024 14:21
@@ -5,24 +5,26 @@
{% block body_class %}template-password-required{% endblock %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve the issue on dark mode, I think this will do the trick:

Suggested change
{% block theme_class %}{% endblock %}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted this slightly to go for theme--light

@kbayliss
Copy link

@jhancock532 LGTM!

@jhancock532 jhancock532 merged commit 988150b into main Feb 21, 2024
3 checks passed
@jhancock532 jhancock532 deleted the fix/password-required-page-styles branch February 21, 2024 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants