Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming view to trailing and leading and adding rtl support. #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aloisdeniel
Copy link

@aloisdeniel aloisdeniel commented Apr 24, 2021

I renamed view1 and view2 to trailing and leading, which I find more clear (we already have those terms in AppBar, GridTileBar, ListTile for example).

This PR also adds rtl support which means that leading and trailing views are inverted when the text direction of the application is rtl and the mode is horizontal.

Renaming view to `trailing` and `leading`. Adding `rtl` support.
@toshiaki-h
Copy link
Owner

Thank you for your PR. But I'm not going to accept this PR.
Because now I'm working on replacing view1 and view2 with children, but I don't think the leading and trailing fit into that name.
However, rtl thinks I need it too, so I'm thinking of take in that part.

@aloisdeniel
Copy link
Author

Oh yes, a List<Widget> children is even better!

And Flex / Column / Row have a textDirection property which makes rtl easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants