Fix for issue #18 (add .svg and .pdf support) #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dotPlotly/issues/18)
Issue raised by @Sven-Winter and @Jwindler suggested altering
ggsave()
argument to .pdf.I implemented this including adding CLI options to the parser:
--pdf-plot-on
and--svg-plot-on
. Defaults for both args are set to toFALSE
to be consistent with existing behaviour. I chose long-form arguments as the obvious single letter (-f -v -g -p
) forms were either already taken or ambiguous in meaning.Consistent with the existing README.md but I also added a simpler example (
MPA01-vs-PA01.minimap2.paf
) at master...lonelyjoeparker:dotPlotly-issue-18:master#diff-cbccb4caeac8ae21fecaaabaab0b3548186ceeb961b37d23a167beeaf7d2dfb4 that executes more quickly, to facilitate testing; and a.gitignore
file to exclude the various outputs from the repo (again, so users/coders can verify example below is working).Fix and testing:
This now has the following behaviour which I believe validates this PR as working:
DEFAULT CASE: No .pdf or .svg enabled:
POSITIVE case: .pdf and .svg both enabled:
(NB, tested but not shown - alternately toggling .pdf OR .svg behaviour works as expected too)
HELP -h behaviour: