不要な close 関数を削除した #1000
Merged
不要な close 関数を削除した #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod backend + PR dashboard) → https://1000.ns-preview.trapti.tech/ |
cp-20
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるか
feedback で特定の条件のみ、 URL delete ボタンで windowclose 関数が発動していた
fix #999
特定の条件というのは、 app/{appId} の URL パスに対して新規ウィンドウでアクセスした場合のみ、
の発動条件のうち後者に該当してしまうため発火していた
https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-window-close
これ以外の場合は本来設定されていた関数が発動されていなかっただけなので想定は window を閉じることであるように見受けられるが、使用感や今回上がった feedback からそもそも閉じないほうが便利だと考えたので閉じる関数の廃止に至った
やったこと
閉じないほうが便利そうだったので、その記述自体を削除した
やらなかったこと
特になし
資料