Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New taxon list #783

Merged
merged 18 commits into from
Nov 10, 2023
Merged

New taxon list #783

merged 18 commits into from
Nov 10, 2023

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Nov 5, 2023

  • the updated taxon list. Back to only having taxa that are in AusTraits (no longer entire APC accepted list), since there is again a functional to rebuild it.

  • also streamlining/including phrase names that aren't in APC & changing function to rebuild taxon list accordingly.

  • lots of iterative testing that additions/subtractions to taxon list show up nicely in commits

  • as a final step I re-organised columns - take a look to see if you'd change further

ehwenk added 11 commits November 2, 2023 20:59
new taxon list - created using new function.
Confirming that changes now show up in a readable manner - and that unneeded names are removed when `replace = TRUE`.

Testing by streamlining some replacements from the floras
& updating the taxon list to confirm it keeps changing as expected
.. have cyclically rebuilt AusTraits, taxon_list, AusTraits, etc. several times and confirm nothing is changing
- had duplicate column
- continuing to collapse instances of same name across datasets
@ehwenk ehwenk requested a review from dfalster November 5, 2023 21:12
Adding here to avoid another branch - unmapping Sjostrom for life_history, plant_growth_form - made too many assumptions, and now we have better datasets
resort again... not sure what happened
rebuild taxon_list without NA's
change function to select, order columns; remove NA's
one minor change as APCalign sorted out
- rename taxon_id_genus
- fix taxon_id_family mappings for taxa with `unknown` taxonomic status
forgot to delete substitutions when I removed traits

[skip ci]
@ehwenk ehwenk merged commit 8f76155 into develop Nov 10, 2023
@ehwenk ehwenk deleted the new-taxon_list branch November 10, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants