-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New taxon list #783
Merged
Merged
New taxon list #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new taxon list - created using new function.
Confirming that changes now show up in a readable manner - and that unneeded names are removed when `replace = TRUE`. Testing by streamlining some replacements from the floras
& updating the taxon list to confirm it keeps changing as expected
…nknown` species (phrase names, new names)
- had duplicate column - continuing to collapse instances of same name across datasets
Adding here to avoid another branch - unmapping Sjostrom for life_history, plant_growth_form - made too many assumptions, and now we have better datasets
resort again... not sure what happened
rebuild taxon_list without NA's
change function to select, order columns; remove NA's
one minor change as APCalign sorted out
forgot to delete substitutions when I removed traits [skip ci]
dfalster
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the updated taxon list. Back to only having taxa that are in AusTraits (no longer entire APC accepted list), since there is again a functional to rebuild it.
also streamlining/including phrase names that aren't in APC & changing function to rebuild taxon list accordingly.
lots of iterative testing that additions/subtractions to taxon list show up nicely in commits
as a final step I re-organised columns - take a look to see if you'd change further