Ballista Bolts issues

[mugg91]

Description

• Bolts don't collide with solid obstructors - fixed by [fixed] mechanisms #2219
• Bolts don't activate pressure plates
• When Bolt is destroyed, gib particles should fly instead of falling straight down.

[Gingerbeard5773]

bolts don't collide with custom tiles (and the obstructor is a custom tile)! It can easily be fixed at line 278 BallistaBolt.as

the engine has two solid tile checks. the first checks the tile type, and this directs to ONLY engine tiles, so custom tiles are not registered. the second actually checks if the tile has the 'solid' tile flag, which will work with custom tiles.

bool isTileSolid(uint16 tile)         //what ballista bolt currently uses
bool isTileSolid(const Tile&in tile)  //what it should be using instead

[mugg91]

@Gingerbeard5773
Thank you for this information.
I managed to fix the issue at near line 130 with

		Tile tile = map.getTile(temp_position);

		if (map.isTileSolid(tile))
		{
			(...)

			BallistaHitMap(this, offset, temp_position, velocity, damage, Hitters::ballista);

BallistaHitMap() (at near line 278) seems to just tell what should happen after the fact.

That being said, I found that your #2219 already resolved the collision issue. (Obstructor will even take damage which is better than not taking damage if the above solution was applied.)

[Gingerbeard5773]

That being said, I found that your #2219 already resolved the collision issue.

The ballista bolt is still incompatible with mods that use custom tiles, and the bolt will phase straight through