[fixed] Spikes sometimes hiding behind grass #2278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2270
This applies
this.getSprite().SetZ(500);inonSetStatic()instead of applying it based on a tag inonTick()in code that is prone to behave differently between online and offline ( see #2277 ).Applying it in
onSetStatic()is already done by ladders.Ladder.asappliesthis.getSprite().SetZ(-40);in itsonSetStatic(), making it always be behind grass.So since this method is already done, it should be acceptable to do it with spikes, to place them always in front of grass.
Tested in offline and online, works.