[fixed] Invincibility is lost after setting the position when tunnel travelling, instead of before #2287
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugg91
changed the title
mugg91
changed the title
|
I tested on dedicated server with a modified knight bot who keeps slashing at my tunnel. Before (Bug)(At 0:16) TunnelInvBug.mp4After (Fix)TunnelInvFix.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2281
This changes
TunnelTravel.as.Previously, invincible tag was removed and then the players's position got set to the destination tunnel.
This caused an issue were you could get hit from attacks that happened at the origin tunnel.
This PR changes that so you get set to the client's position and then another command is sent that untags invincible.
I tested with 50~250 ping on dedicated server and got killed by the saw at the destination tunnel every time.
I couldn't verify the fix itself yet though. If I do, I will update here.I verified the fix, see the videos in my next post.