Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow for running tests #40

Closed

Conversation

samuell
Copy link
Contributor

@samuell samuell commented Dec 18, 2024

As a first attempt at addressing #39 , this PR adds a somewhat minimal GitHub Actions workflow that:

  • Runs a basic flake8 lint (warns mostly, only fails on critical issues)
  • Runs pytest which right now just contains of a test placeholder (to keep the PR small)
  • Runs the example workflows previously defined in .gitlab-ci.yml

It also adds a badge for the status of the tests, in README.md.

Worth noting:

  • The workflow uses Python 3.6.15, as 3.6 is specified as the lowest requirement in environment.yml, and since this is a bit of an old version, it requires the slightly older ubuntu-20.04 image. This could perhaps be updated later.
  • Right now the workflow is run on any push. One could limit this to only run on e.g. PRs towards master or similar.

@samuell samuell closed this Dec 18, 2024
@samuell
Copy link
Contributor Author

samuell commented Dec 18, 2024

Sorry, this PR was accidentally created from the wrong branch, so opened #41 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant