Handle context cancellation in fact gatherers #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
reviewed
Feb 3, 2025
| log.Error(SapcontrolWebmethodError. | ||
| Wrap(fmt.Sprintf("argument %s for %s/%s", factReq.Argument, sid, instanceName)). | ||
| Wrap(err.Error())) | ||
| continue |
There was a problem hiding this comment.
Maybe here we need to do other error checking.
Before the if err != nil, we could check if the context is done, so we avoid continue iterating and we early return the error.
| continue | ||
| } | ||
| results := make(chan []entities.Fact) | ||
| go func() { |
There was a problem hiding this comment.
question: why do we need a go routine?
i think we could keep everything in one thread, and in s.gatherSingle we could return facts, err, and if we have an error (caused by ctx being cancelled) simply return with an error.
it would make the code flow and testing easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #376, handle context cancellation in the following gatherers