Add a button to download upgradable packages as CSV #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvhs
added
javascript
janvhs
force-pushed
the
csv-in-upgradable-packages
branch
from
844249e to
9d60434
Compare
EMaksy
force-pushed
the
csv-in-upgradable-packages
branch
from
1683d5a to
b731206
Compare
EMaksy
reviewed
Nov 6, 2024
| render: (content, _) => <div className="font-bold">{content}</div>, | ||
| }, | ||
| { | ||
| title: 'Latest Package', | ||
| key: 'latestPackage', | ||
| key: 'latest_package', |
There was a problem hiding this comment.
Wondering with which naming convention we want to stick on this ?
As we do it different through the project xD
@janvhs , @dottorblaster ideas ?
EMaksy
changed the title
arbulu89
reviewed
Nov 6, 2024
assets/js/common/UpgradablePackagesList/UpgradablePackagesList.test.jsx
Outdated
Show resolved
Hide resolved
assets/js/pages/HostRelevantPatches/HostRelevantPatchesPage.jsx
Outdated
Show resolved
Hide resolved
This commit fixes the CSV download to include all patches instead of only the patches, matching the search. Furthermore, it cleans up the JavaScript a bit
EMaksy
force-pushed
the
csv-in-upgradable-packages
branch
from
56a0891 to
c704f16
Compare
arbulu89
approved these changes
Nov 7, 2024
assets/js/pages/UpgradablePackagesPage/UpgradablePackages.test.jsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a CSV download button to include all patches to the UpgradablePackages view.
Preview
How was this tested
What is open ?