Fix selected cluster type ui in Checks catalog view #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
added
bug
EMaksy
commented
Jan 14, 2025
EMaksy
force-pushed
the
add_missing_icon_cluster_types
branch
from
97146d2 to
94f552c
Compare
EMaksy
changed the title
EMaksy
force-pushed
the
add_missing_icon_cluster_types
branch
from
94f552c to
7543726
Compare
EMaksy
force-pushed
the
add_missing_icon_cluster_types
branch
from
eb332f5 to
b812f47
Compare
EMaksy
force-pushed
the
add_missing_icon_cluster_types
branch
from
b812f47 to
d79e746
Compare
arbulu89
reviewed
Jan 22, 2025
| @@ -93,12 +93,15 @@ context('Checks catalog', () => { | |||
| }); | |||
|
|
|||
| describe('Filtering', () => { | |||
| const selectedIconSelector = | |||
There was a problem hiding this comment.
question @EMaksy :
why did you create this constant and put in all the array entries?
I mean, you could simply have the constant and use it in the test, right?
There was a problem hiding this comment.
Very fair point, when working on this first i thought the ui selector would be different, but nope.
You are right we can just test directly, will create a follow up pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will restore the previous ui behaviour in the checks catalog view. When selecting a cluster type in the checks catalog the green svg icon is not rendered.
With the latest changes in #3210 we now not only pass a string as value, which was handled by the built in headless ui
selectedboolean, but also an object{ type, hanaScenario }. Check out the official docs https://headlessui.com/v1/react/listbox#listbox-optionWith using the lodash isEqual we now use a "deep comparison" to ensure accurate evaluation of selected options.
For this we use the "by" value provided by Listbox:
You can also pass your own comparison function to the by prop if you'd like complete control over how objects are comparedSource: https://headlessui.com/v1/react/listbox#binding-objects-as-values
Demo:
Screencast.From.2025-01-14.17-16-08.mp4
Test
Enriched existing e2e test to test that the SVG is rendered