introduce NRF and BLE drivers #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
changed the base branch from
main
to
tychovrahe/refactor/usb_events
|
TychoVrahe
requested review from
cepetr
and removed request for
prusnak and
matejcik
cepetr
requested changes
Jan 2, 2025
mmilata
reviewed
Jan 2, 2025
cepetr
requested changes
Jan 3, 2025
mmilata
reviewed
Jan 6, 2025
cepetr
requested changes
Jan 6, 2025
TychoVrahe
force-pushed
the
tychovrahe/T3W1/nrf_ble_driver
branch
from
601953e to
87610cc
Compare
mmilata
reviewed
Jan 7, 2025
| // If the message is already sent or the id is not found, it does nothing and | ||
| // returns false If the message is queued, it will be removed from the queue If | ||
| // the message is being sent, it will be sent. The callback will not be called. | ||
| bool nrf_abort_msg(int32_t id); |
There was a problem hiding this comment.
Aborting messages introduces a bunch of complexity into the queue code, where are we even going to use it?
There was a problem hiding this comment.
Probably will when going to low power modes, there will also be other services that might need that. cc also @cepetr
cepetr
requested changes
Jan 9, 2025
TychoVrahe
force-pushed
the
tychovrahe/refactor/usb_events
branch
from
f5a0f84 to
aac111f
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3W1/nrf_ble_driver
branch
from
ed61578 to
a2622a6
Compare
[no changelog]
[no changelog]
[no changelog]
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/T3W1/nrf_ble_driver
branch
from
a2622a6 to
d4bf0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces NRF driver, responsible for handling communication with NRF, and BLE driver, which provides interface for using BLE via the NRF.