-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(legacy): show XPUB using a QR code #4480
Conversation
|
Do all possible XPUBs (bip-44, 49, 84, 86) fit on the device screen? |
b080e89
to
cadcda3
Compare
The screenshot below is for The QR code is rendered with a higher resolution, and looks like it fits on the screen: @prusnak I will make sure that we have tests covering all XPUB types. |
Yes, it fits. But I doubt this can be read by any camera. Even QR codes with doubled pixels are quite problematic to be read by most of the cameras from T1 display. I am not saying we should not merge this PR, I am just saying that doing so probably does not add much value unfortunately. :-/ |
No strong opinion. I am fine with both approaches. Maybe we can show the QR for consistency with GetAddress, but like I said, scanning it might be very problematic. |
It can be read by iPhone (13) camera. Older phones might have a problem. I don't think that lot of users do that anyway. Therefore I would proceed with the pr and leave the qr there for consistency. |
ACK |
Similar layout to `fsm_layoutAddress` is used. Fixes #3043.
ef094a2
to
423ec24
Compare
tested on my Nothing phone 1 with Android 15 |
Similar layout to
fsm_layoutAddress
is used.Fixes #3043.