Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong RSOD color on some older Model T devices #4491

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix wrong RSOD color on some older Model T devices #4491

merged 1 commit into from
Jan 14, 2025

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Jan 12, 2025 •
edited
Loading

note to self: dont forget to sync the new ifdefs with #4477

@TychoVrahe TychoVrahe self-assigned this Jan 12, 2025
@TychoVrahe TychoVrahe force-pushed the tychovrahe/fix_t_rsod_colors branch from 028b8db to 64c7185 Compare January 12, 2025 14:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe marked this pull request as ready for review January 13, 2025 07:53
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner January 13, 2025 07:53
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak January 13, 2025 07:53
@bosomt
Copy link

bosomt commented Jan 13, 2025

QA OK

RSOD is red again :)

Info:

  • Suite version: desktop 25.1.1 (11cab04dfc05ddb63cb6279bbc289994bf6c0583)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/25.1.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.7 regular (revision f309fcb)
  • Transport: BridgeTransport 3.0.0-bundled.25.1.1

cepetr
cepetr approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@TychoVrahe TychoVrahe force-pushed the tychovrahe/fix_t_rsod_colors branch from 64c7185 to 3056ffa Compare January 13, 2025 15:55
@TychoVrahe TychoVrahe merged commit 34e033f into main Jan 14, 2025
95 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/fix_t_rsod_colors branch January 14, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TychoVrahe @bosomt @cepetr