Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup/shutdown refactoring #4499

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Startup/shutdown refactoring #4499

wants to merge 11 commits into from
+1,281 −1,788

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Jan 14, 2025 •
edited
Loading

This PR includes significant refactoring of the startup and shutdown code.

  1. The startup and shutdown code has been simplified and mostly unified across all platforms.
  2. Many linker script symbols have been renamed for greater consistency.
  3. A large portion of assembler code has been rewritten in C.
  4. The RSOD screen is now displayed after all SRAM and other sensitive data are cleared.
  5. An option to wait and reboot after an RSOD is displayed has been added.

@cepetr cepetr self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@cepetr cepetr force-pushed the cepetr/shutdown-refactoring branch 5 times, most recently from f322b61 to a3cdadf Compare January 14, 2025 17:09
@cepetr cepetr force-pushed the cepetr/shutdown-refactoring branch from a3cdadf to 13b756d Compare January 16, 2025 12:18
@cepetr cepetr force-pushed the cepetr/shutdown-refactoring branch from 13b756d to e3542c3 Compare January 16, 2025 13:28
@cepetr cepetr added bootloader core Bootloader for Trezor core T2B1 Trezor Safe 3 (F4) T3W1 T2T1 Trezor Model T T3T1 Trezor Safe 5 T3B1 Trezor Safe 3 (U5) labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak Awaiting requested review from prusnak prusnak will be requested when the pull request is marked ready for review prusnak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@cepetr cepetr

Labels
bootloader core Bootloader for Trezor core T2B1 Trezor Safe 3 (F4) T2T1 Trezor Model T T3B1 Trezor Safe 3 (U5) T3T1 Trezor Safe 5 T3W1
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cepetr