Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for setting BLE name from Trezor firmware #4504

Merged
merged 1 commit into from
Jan 23, 2025
Merged

add support for setting BLE name from Trezor firmware #4504

merged 1 commit into from
Jan 23, 2025

Conversation

TychoVrahe
Copy link
Contributor

Expands the ble_issue_command to support adding data.

Allows sending the name to NRF (this will then be used for advertising and GATT)

@TychoVrahe TychoVrahe self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/bt_name branch 2 times, most recently from 3259cda to 20347e8 Compare January 15, 2025 14:27
@TychoVrahe TychoVrahe marked this pull request as ready for review January 16, 2025 08:14
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner January 16, 2025 08:14
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak January 16, 2025 08:14
cepetr
cepetr requested changes Jan 17, 2025
View reviewed changes
core/embed/io/ble/stm32/ble.c Outdated Show resolved Hide resolved
core/embed/io/ble/inc/io/ble.h Outdated Show resolved Hide resolved
cepetr
cepetr approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/bt_name branch from 2e5e720 to 68576c7 Compare January 23, 2025 10:43
@TychoVrahe TychoVrahe merged commit a5809c8 into main Jan 23, 2025
94 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/T3W1/bt_name branch January 23, 2025 12:28
@TychoVrahe TychoVrahe mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TychoVrahe @cepetr