Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): check that translations are using correct layout names #4543

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(python): check that translations are using correct layout names #4543

merged 1 commit into from
Jan 28, 2025

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 28, 2025

Following #4495 (review).

[no changelog]

@romanz romanz added the translations Put this label on a PR to run tests in all languages label Jan 28, 2025
@romanz romanz self-assigned this Jan 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz requested a review from obrusvit January 28, 2025 09:07
@romanz romanz marked this pull request as ready for review January 28, 2025 09:23
@romanz romanz requested a review from matejcik as a code owner January 28, 2025 09:23
@romanz romanz removed the request for review from matejcik January 28, 2025 09:24
obrusvit
obrusvit reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise 👍

python/src/trezorlib/_internal/translations.py Show resolved Hide resolved
@romanz romanz force-pushed the romanz/translations-layout-name-check branch from 71701e5 to 0b88d15 Compare January 28, 2025 12:30
@romanz romanz merged commit 5cdd0e7 into main Jan 28, 2025
137 of 138 checks passed
@romanz romanz deleted the romanz/translations-layout-name-check branch January 28, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

Assignees

@romanz romanz

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanz @obrusvit