Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify size of enums between rust and C #4545

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

TychoVrahe
Copy link
Contributor

By default, ARM eabi has -fshort-enums switched on, so we need to pass this flag to clang when building bindings for rust to account for this behavior.

For contrast, unix builds don't use this. SDL also enforces building without this flags via static asserts, so we can't use -fshort-enums for the whole of unix, so i opted for using different settings for unix and embedded targets.

@TychoVrahe TychoVrahe self-assigned this Jan 28, 2025
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner January 28, 2025 10:38
@TychoVrahe TychoVrahe requested review from mmilata and removed request for prusnak January 28, 2025 10:39
Copy link

github-actions bot commented Jan 28, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

core/embed/rust/build.rs Outdated Show resolved Hide resolved
core/embed/rust/build.rs Outdated Show resolved Hide resolved
@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/fix_build_enums branch from e9407a7 to 33b33b1 Compare January 28, 2025 18:33
@TychoVrahe TychoVrahe merged commit 671c3e2 into main Jan 29, 2025
94 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/T3W1/fix_build_enums branch January 29, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

3 participants