-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log firmware revision check to Sentry on mobile #16386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Expo preview is ready!
|
Lemonexe
commented
Jan 15, 2025
Lemonexe
changed the title
Feat/fw check sentry mobile
Firmware revision check Sentry on mobile
Jan 15, 2025
Lemonexe
changed the title
Firmware revision check Sentry on mobile
Log firmware revision check to Sentry on mobile
Jan 15, 2025
Lemonexe
force-pushed
the
feat/fw-check-sentry-mobile
branch
from
January 15, 2025 11:40
02de286
to
0d974db
Compare
Lemonexe
force-pushed
the
feat/fw-check-sentry-mobile
branch
from
January 15, 2025 13:02
cf72b69
to
0cadd73
Compare
matejkriz
reviewed
Jan 15, 2025
matejkriz
reviewed
Jan 15, 2025
matejkriz
reviewed
Jan 15, 2025
Lemonexe
force-pushed
the
feat/fw-check-sentry-mobile
branch
from
January 15, 2025 17:10
0cadd73
to
2b75861
Compare
Lemonexe
force-pushed
the
feat/fw-check-sentry-mobile
branch
from
January 17, 2025 15:37
9f3d82a
to
f35c261
Compare
matejkriz
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step to implement FW revision check in Mobile - just log the result to Sentry in background, no UI.
ℹ️ FYI the check has been done silently for months in suite native, because Connect does it automatically.
useDeviceCompromised
hook that sends Sentry exception if the check failedTesting
1-main
or2-main
(those versions always fail the check)Related Issue
Resolve #16379