Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log firmware revision check to Sentry on mobile #16386

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Jan 15, 2025

Description

First step to implement FW revision check in Mobile - just log the result to Sentry in background, no UI.
ℹ️ FYI the check has been done silently for months in suite native, because Connect does it automatically.

  • prepare redux state and selectors
    • may seem superfluous now, but I'll build on it in #16273
  • add useDeviceCompromised hook that sends Sentry exception if the check failed

Testing

  • you may merge #16356 locally into this branch to easily turn on Sentry for testing
  • start emulator with 1-main or 2-main (those versions always fail the check)
  • you should see a new sentry issue such as this one

Related Issue

Resolve #16379

Copy link

github-actions bot commented Jan 15, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 22
  • More info

Learn more about 𝝠 Expo Github Action

@Lemonexe Lemonexe marked this pull request as ready for review January 15, 2025 11:15
@Lemonexe Lemonexe requested a review from a team as a code owner January 15, 2025 11:15
@Lemonexe Lemonexe changed the title Feat/fw check sentry mobile Firmware revision check Sentry on mobile Jan 15, 2025
@Lemonexe Lemonexe changed the title Firmware revision check Sentry on mobile Log firmware revision check to Sentry on mobile Jan 15, 2025
@Lemonexe Lemonexe force-pushed the feat/fw-check-sentry-mobile branch from 02de286 to 0d974db Compare January 15, 2025 11:40
@MiroslavProchazka MiroslavProchazka added the mobile Suite Lite issues and PRs label Jan 15, 2025
@Lemonexe Lemonexe force-pushed the feat/fw-check-sentry-mobile branch from cf72b69 to 0cadd73 Compare January 15, 2025 13:02
@Lemonexe Lemonexe force-pushed the feat/fw-check-sentry-mobile branch from 9f3d82a to f35c261 Compare January 17, 2025 15:37
Copy link
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Lemonexe Lemonexe merged commit 591ce46 into develop Jan 17, 2025
80 checks passed
@Lemonexe Lemonexe deleted the feat/fw-check-sentry-mobile branch January 17, 2025 16:33
Copy link

sentry-io bot commented Jan 20, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report FW revision check to Sentry in mobile
3 participants