-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect-popup-refactor [2/3] (passphrase and error screen) #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
popup-react-passphrase
branch
from
July 30, 2022 13:02
d00af10
to
df7d578
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
2 times, most recently
from
August 17, 2022 13:36
e581fe3
to
e3b6b72
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
from
August 22, 2022 12:17
e3b6b72
to
f9ac322
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
3 times, most recently
from
August 31, 2022 07:20
877453d
to
4698803
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
3 times, most recently
from
September 1, 2022 12:58
02afe40
to
d2cb842
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
4 times, most recently
from
September 12, 2022 09:38
acaacfe
to
9c8637a
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
12 times, most recently
from
September 16, 2022 08:08
c9b25bd
to
6ee22ca
Compare
mroz22
changed the title
[wip] connect-popup-refactor [2/3]
connect-popup-refactor [2/3] (passphrase and error screen)
Sep 16, 2022
mroz22
requested review from
matejkriz,
tomasklim,
szymonlesisz,
sime and
dahaca
as code owners
September 16, 2022 08:56
mroz22
commented
Sep 19, 2022
mroz22
force-pushed
the
popup-react-passphrase
branch
from
September 19, 2022 11:02
6ee22ca
to
df7f54e
Compare
karliatto
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a comment for a log that looks like forgotten.
mroz22
commented
Sep 19, 2022
mroz22
force-pushed
the
popup-react-passphrase
branch
from
September 19, 2022 16:05
df7f54e
to
25b22b2
Compare
mroz22
force-pushed
the
popup-react-passphrase
branch
from
September 19, 2022 16:11
25b22b2
to
53f9e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still draft. Some parts of code will move to separate PRs
<Translation>
componentsummary:
Issues: