Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect-popup-refactor [2/3] (passphrase and error screen) #5879

Merged
merged 10 commits into from
Sep 19, 2022

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Jul 29, 2022

This is still draft. Some parts of code will move to separate PRs

summary:

  • the first commit moves Passphrase subcomponets component into @trezor/components so that I can reuse it. Looking forward to any ideas how to do it better. But I would like to proceed with this PR rather sooner than later. cc @tomasklim @dahaca
  • the second commit moves CollapsibleBox component into @trezor/components. I am going to need that in connect-ui.
  • the third commit adds some new icons in @trezor/components
  • the fourth commit splits types in @trezor/connect. I am not very happy about this one, but I wasn't able to make typescript work when trying to create strongly typed interface later in @trezor/connect-ui package. Any typescript magician around to discuss that?
  • the fifth commit turns standalone connect-ui components into something I would call connect-ui app. it adds also support for future stuff such as theming or internationalization
  • the other commits are refactoring old connect-popup into connect-ui without any changes except for commits:
    • feat(connect-ui): add error screen which adds timeout to loading of popup and prevents popup closing when there is an error or timeout is reached
    • feat(connect-ui): add Passphrase view which implements suite-like passphrase flow

Issues:

@mroz22 mroz22 force-pushed the popup-react-passphrase branch from d00af10 to df7d578 Compare July 30, 2022 13:02
@mroz22 mroz22 force-pushed the popup-react-passphrase branch 2 times, most recently from e581fe3 to e3b6b72 Compare August 17, 2022 13:36
@mroz22 mroz22 force-pushed the popup-react-passphrase branch from e3b6b72 to f9ac322 Compare August 22, 2022 12:17
@mroz22 mroz22 force-pushed the popup-react-passphrase branch 3 times, most recently from 877453d to 4698803 Compare August 31, 2022 07:20
@mroz22 mroz22 force-pushed the popup-react-passphrase branch 3 times, most recently from 02afe40 to d2cb842 Compare September 1, 2022 12:58
@mroz22 mroz22 force-pushed the popup-react-passphrase branch 4 times, most recently from acaacfe to 9c8637a Compare September 12, 2022 09:38
@mroz22 mroz22 force-pushed the popup-react-passphrase branch 12 times, most recently from c9b25bd to 6ee22ca Compare September 16, 2022 08:08
@mroz22 mroz22 changed the title [wip] connect-popup-refactor [2/3] connect-popup-refactor [2/3] (passphrase and error screen) Sep 16, 2022
@mroz22 mroz22 marked this pull request as ready for review September 16, 2022 08:56
Copy link
Member

@karliatto karliatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a comment for a log that looks like forgotten.

@mroz22 mroz22 force-pushed the popup-react-passphrase branch from df7f54e to 25b22b2 Compare September 19, 2022 16:05
@mroz22 mroz22 force-pushed the popup-react-passphrase branch from 25b22b2 to 53f9e65 Compare September 19, 2022 16:11
@mroz22 mroz22 merged commit 22d82a9 into develop Sep 19, 2022
@mroz22 mroz22 deleted the popup-react-passphrase branch September 19, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants