build: implement eslint and prettier #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sambauers
commented
Mar 10, 2023
•
sambauers
commented
- Implemented formatting standards that closely match NextJS
- Added a linting workflow
- Prefer arrow functions
- Stop using default exports
sambauers
commented
Mar 10, 2023
| @@ -104,7 +103,7 @@ const CSP_OPTION_NAMES = ['mergeDefaultDirectives', 'reportOnly'] as const | |||
| type CSPOptionNamesTuple = typeof CSP_OPTION_NAMES | |||
| type CSPOptionNames = CSPOptionNamesTuple[number] | |||
| type CSPOptionsConfig = { | |||
| [Name in CSPOptionNames]?: Boolean | |||
There was a problem hiding this comment.
This was pretty much the only real bug that linting picked up.
|
Hey! Thanks for the PR, however we already have plans on linting and formatting as I mentioned in #50. My apologies for not being clear that it was a specific implementation I was working on, and not just a general desire to implement the tooling. I'll get our intended config/tooling up later today when I can. Admittedly, it's only been held back because I got distracted with #41. I was experimenting on ways to tackle it when I was spending time on this project earlier last week. |
|
No problem. Feel free to steal anything from this PR that looks good to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.