Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npc bots #3

Closed
wants to merge 455 commits into from
Closed

Npc bots #3

wants to merge 455 commits into from

Conversation

kissingers
Copy link

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

github-actions bot and others added 30 commits November 18, 2023 01:03
* fix(Scripts/quest): Improve The Force of Neltharaku

* update
…core#17778)

chore(Game/OutdoorPvP): cleanup ptr's, private fields
* chore(Cleanup): sort includes

* fix build

* fix build again
* fix(DB/Creature): Delete previous spawn of Leotheras

* Update rev_1700326661784669100.sql

* Update rev_1700326661784669100.sql
azerothcore#17781)

* fix(DB/Gameobject): Sniffed Values for remaining 'Alliance Bonfire' spawns

* update for compact DELETE statement
azerothcore#17786)

* fix(Scripts/SSC): Fix being able to damage Leo's minions if you are not the target player

* implement helper

* Update Creature.cpp

* Update Creature.h
…ns (azerothcore#17783)

* fix(DB/Gameobject): Sniffed Values for remaining 'Horde Bonfire' spawns

* update for compact DELETE statement
github-actions bot and others added 28 commits December 11, 2023 22:58
…erothcore#17990)

* fix(Scripts/Commands): fix wpgps and add sai option for formating

* ???
azerothcore#17957)

fix(DB/Creature): Sniffed Values for 26258 '[DND] Midsummer Bonfire Faction Bunny - A'
…azerothcore#17956)

* fix(DB/Creature): Sniffed Values for 17066 'Ribbon Pole Debug Target'

* add missing DELETE for creature_addon
…7964)

* fix (Event/Midsummer): miscellaneous cleanups of spawns

* update comments

* add missing id1 filter to where clause

* add missing ticks
azerothcore#18002)

* fix(Scripts/SerpentshrineCavern): Use proper spells to handle the Lurker spout rotation

* Update boss_lurker_below.cpp
azerothcore#18003)

fix(Scripts/SerpentshrineCavern): fix Hydross not casting Water Tomb & Vile Sludge
@kissingers kissingers closed this Dec 14, 2023
@kissingers kissingers deleted the NPCBots branch December 14, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.