-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bun runtime by downgrading to 1.1.24 #1409
Conversation
🦋 Changeset detectedLatest commit: 39cb7d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request addresses an Inter-Process Communication (IPC) bug in the Bun runtime by pinning the Bun version to 1.1.24 or lower and updating the associated documentation. The changes include modifications to the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/guides/frameworks/bun.mdx (1)
Line range hint
89-91
: Consider updating the "Known issues" section.While the warning about the Bun version requirement is well-placed at the beginning of the document, it would be beneficial to also mention this issue in the "Known issues" section at the end. This ensures that users who skip to this section are aware of the version constraint and the IPC bug.
Consider adding the following point to the "Known issues" section:
- There is a known IPC bug in Bun versions higher than 1.1.24 that affects the `dev` command. Users should use Bun version 1.1.24 or lower as mentioned in the warning at the top of this guide.🧰 Tools
🪛 LanguageTool
[grammar] ~14-~14: The word “setup” is a noun. The verb is spelled with a space.
Context: ...r Bun. This guide will show you have to setup Trigger.dev in your existing Bun projec...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- .changeset/wicked-paws-accept.md (1 hunks)
- docs/guides/frameworks/bun.mdx (1 hunks)
- packages/cli-v3/src/deploy/buildImage.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .changeset/wicked-paws-accept.md
🧰 Additional context used
🔇 Additional comments (2)
docs/guides/frameworks/bun.mdx (1)
12-13
: Excellent addition of the version requirement warning.The warning message is clear, informative, and well-placed at the beginning of the document. It provides users with crucial information about the Bun version requirement, explains the reason (IPC bug), and offers a solution with the installation command.
packages/cli-v3/src/deploy/buildImage.ts (1)
467-467
: Pinning Bun to version 1.1.24 in DockerfileThe change to use
imbios/bun-node:1.1.24-22-slim@sha256:9cfb7cd87529261c482fe17d8894c0986263f3a5ccf84ad65c00ec0e1ed539c6
as the base image effectively downgrades Bun to version 1.1.24, addressing the IPC bug in later versions.
commit: |
There's currently a bug in Bun IPC oven-sh/bun#13799 that affects versions > 1.1.24. This will only fix deploy, not dev. For successful dev runs, you will have to downgrade your local Bun version:
curl -fsSL https://bun.sh/install | bash -s -- bun-v1.1.24
Summary by CodeRabbit
Bug Fixes
Documentation
Improvements