Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro #13756

MalachiTimothyPhillips · 2025-01-29T17:20:09Z

@trilinos/amesos2

Motivation

This resolves issues on rzadams.

Signed-off-by: malphil <[email protected]>

trilinos-autotester · 2025-01-29T17:23:16Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-01-29T17:28:14Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 1049
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_gcc

Build Num: 1099
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1100
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_clang

Build Num: 1098
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_cuda

Build Num: 1097
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_intel

Build Num: 1018
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1097
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)

Pull Request Author: MalachiTimothyPhillips

trilinos-autotester · 2025-01-29T18:14:45Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 1049
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_gcc

Build Num: 1099
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1100
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_clang

Build Num: 1098
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_cuda

Build Num: 1097
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_intel

Build Num: 1018
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1097
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	client: Sierra
PULLREQUESTNUM	13756
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`fa1cd20`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5f56a7d`

CDash Test Results for PR# 13756.

trilinos-autotester · 2025-01-29T18:15:02Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2025-01-29T18:15:09Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2025-01-30T18:28:25Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jhux2

Who is defining EMPTY?!

iyamazaki · 2025-01-30T18:46:55Z

Thank you for the fix, @MalachiTimothyPhillips !! I guess SuperLU defines and uses EMPTY, which the compiler did not like? I am curious what kind of errors you are seeing?

jhux2 · 2025-01-30T18:53:03Z

Thank you for the fix, @MalachiTimothyPhillips !! I guess SuperLU defines and uses EMPTY, which the compiler did not like? I am curious what kind of errors you are seeing?

That's my guess. What's the version of SuperLU?

iyamazaki · 2025-01-30T18:59:15Z

I thought SuperLU renamed those at some point, but I still see EMPTY in the current version under github...

jhux2 · 2025-01-30T19:02:59Z

I thought SuperLU renamed those at some point, but I still see EMPTY in the current version under github...

@iyamazaki Could you open an issue against SuperLU and link it here?

trilinos-autotester · 2025-01-30T19:03:15Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

trilinos-autotester · 2025-01-30T19:03:21Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jhux2

lgtm

iyamazaki · 2025-01-30T19:09:49Z

@jhux2. Maybe, I need to understand the issue better. I think this has been okay for Amesos2 because these variables are defined inside our SLU namespace. @ndellingwood may know this better

trilinos-autotester · 2025-01-30T19:34:56Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jhux2 ]!

trilinos-autotester · 2025-01-30T19:35:03Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

iyamazaki · 2025-01-30T21:28:08Z

@jhux2. By the way, I meant I want to understand the cause before opening an issue to SuperLU. I think it is okay to undef EMPTY because I don't think we use it in Amesos2 anyway.

We could make a follow-up PR, but maybe we want to do the same for SuperLU_MT at some point?

ndellingwood · 2025-01-30T21:59:18Z

@iyamazaki I did a grep in amesos2, shylu, and common/auxiliarySoftware/SuiteSparse to confirm their is not an occurrence of an EMPTY macro, the macros in each package are prefixed (e.g. AMESOS2_KLU2_EMPTY, TRILINOS_AMD_EMPTY). The definition does not seem to come from Trilinos

Fix Amesos2 + SuperLU issue coming from EMPTY macro

fa1cd20

Signed-off-by: malphil <[email protected]>

MalachiTimothyPhillips added the client: Sierra All issues that primarily impacts SNL Sierra codes label Jan 29, 2025

MalachiTimothyPhillips self-assigned this Jan 29, 2025

MalachiTimothyPhillips requested a review from a team as a code owner January 29, 2025 17:20

jhux2 added the pkg: Amesos2 label Jan 30, 2025

jhux2 requested review from iyamazaki and ndellingwood January 30, 2025 18:43

jhux2 reviewed Jan 30, 2025

View reviewed changes

jhux2 approved these changes Jan 30, 2025

View reviewed changes

jhux2 added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Jan 30, 2025

jhux2 added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Jan 30, 2025

jhux2 changed the title ~~Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro~~ DO NOT MERGE: Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro Jan 30, 2025

jhux2 changed the title ~~DO NOT MERGE: Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro~~ Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro Jan 30, 2025

jhux2 removed the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Jan 30, 2025

jhux2 merged commit dd1423b into develop Jan 30, 2025
14 of 16 checks passed

jhux2 deleted the malachi/add-undef-empty-to-amesos2-superlu branch January 30, 2025 21:52

Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro #13756

Amesos2: Fix Amesos2 + SuperLU issue coming from EMPTY macro #13756

Conversation

MalachiTimothyPhillips commented Jan 29, 2025

Motivation

trilinos-autotester commented Jan 29, 2025

trilinos-autotester commented Jan 29, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

Using Repos:

trilinos-autotester commented Jan 29, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

trilinos-autotester commented Jan 29, 2025

trilinos-autotester commented Jan 29, 2025

trilinos-autotester commented Jan 30, 2025

jhux2 left a comment

Choose a reason for hiding this comment

iyamazaki commented Jan 30, 2025

jhux2 commented Jan 30, 2025

iyamazaki commented Jan 30, 2025

jhux2 commented Jan 30, 2025 • edited Loading

trilinos-autotester commented Jan 30, 2025

trilinos-autotester commented Jan 30, 2025

jhux2 left a comment

Choose a reason for hiding this comment

iyamazaki commented Jan 30, 2025

trilinos-autotester commented Jan 30, 2025

trilinos-autotester commented Jan 30, 2025

iyamazaki commented Jan 30, 2025 • edited Loading

ndellingwood commented Jan 30, 2025

jhux2 commented Jan 30, 2025 •

edited

Loading

iyamazaki commented Jan 30, 2025 •

edited

Loading