Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Context Menu-Only Row Actions #2789

Closed
2 tasks done
rhenness opened this issue Aug 13, 2024 · 3 comments · Fixed by #3097
Closed
2 tasks done

Table: Context Menu-Only Row Actions #2789

rhenness opened this issue Aug 13, 2024 · 3 comments · Fixed by #3097
Assignees
Labels
external-request Bugs and features reported by individuals from other teams in Trimble Version 1.x

Comments

@rhenness
Copy link
Contributor

Prerequisites

Proposal

The current table component displays a number of row actions inline within a designated column. Once the inline space is exhausted, additional actions are placed within a context menu dropdown. This feature request proposes the ability to move all row actions to the context menu dropdown, removing them from the inline display entirely.

Requirements:

  1. Context Menu-Only Actions:

    • Provide an option to configure the table so that all row actions are placed within the context menu dropdown, with none displayed inline.
  2. Icons in Context Menu:

    • Ensure that icons can be displayed next to individual row actions within the context menu.
    • Allow customization of icon colors within the context menu to give the consumer more control.

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Trimble Viewpoint applications

What is your team/division name ?

Trimble Viewpoint

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

Copy link

Hello @ryan-henness-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 13, 2024
@rhenness
Copy link
Contributor Author

rhenness commented Aug 18, 2024

@enowak1031 We may want to escalate this one as it's behaving differently than the majority of design doc requirements. Can this be bumped closer to the front of the review queue?
I am willing to implement the feature

@prashanth-offcl prashanth-offcl moved this from In Review to Refinement in Modus Web Components Aug 19, 2024
@prashanth-offcl
Copy link
Contributor

@enowak1031 We may want to escalate this one as it's behaving differently than the majority of design doc requirements. Can this be bumped closer to the front of the review queue? I am willing to implement the feature

@ryan-henness-trimble Your proposal has been reviewed and accepted by the design team. We would gladly accept your contributions.

PS: Icons in context menu - The modus-list component is used in the dropdown and currently accepts left icon as prop, if your requirement is to show icons on the right side which is one of the variants as per Figma, then we need to change the selected state as well.

@enowak1031 enowak1031 moved this from Refinement to To Do in Modus Web Components Jan 2, 2025
@prashanthr6383 prashanthr6383 self-assigned this Jan 6, 2025
@prashanthr6383 prashanthr6383 moved this from To Do to In Progress in Modus Web Components Jan 6, 2025
@prashanthr6383 prashanthr6383 linked a pull request Jan 7, 2025 that will close this issue
13 tasks
@prashanthr6383 prashanthr6383 moved this from In Progress to PR Review in Modus Web Components Jan 9, 2025
@prashanthr6383 prashanthr6383 moved this from PR Review to In Progress in Modus Web Components Jan 9, 2025
@prashanthr6383 prashanthr6383 moved this from In Progress to QA in Modus Web Components Jan 9, 2025
@jewel-shajan jewel-shajan moved this from QA to PR Review in Modus Web Components Jan 10, 2025
@github-project-automation github-project-automation bot moved this from PR Review to Done in Modus Web Components Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble Version 1.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants