Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Row action menu only feature #3097

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Jan 7, 2025

Description

References

Fixes #2789

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@prashanthr6383 prashanthr6383 requested a review from a team as a code owner January 7, 2025 07:50
@prashanthr6383 prashanthr6383 linked an issue Jan 7, 2025 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 9165f27
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6780da277086b10008a5c1fc
😎 Deploy Preview https://deploy-preview-3097--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 33 (🔴 down 14 from production)
Accessibility: 75 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 changed the title Table row action menu only init and storybook update Table: Row action menu only feature Jan 7, 2025
@prashanthr6383 prashanthr6383 marked this pull request as draft January 7, 2025 11:41
@jewel-shajan
Copy link

jewel-shajan commented Jan 9, 2025

@prashanthr6383Is it acceptable to use different sizes for icons inside and outside the overflow button?
image

@prashanthr6383 prashanthr6383 marked this pull request as ready for review January 10, 2025 08:32
@prashanthr6383 prashanthr6383 added the modus-table Modus Table component development label Jan 10, 2025
@prashanthr6383
Copy link
Collaborator Author

@prashanthr6383Is it acceptable to use different sizes for icons inside and outside the overflow button? image

@jewel-shajan This requires the changes to modusIcon component so we are skipping this.

Copy link

@jewel-shajan jewel-shajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed and ready for PR Review.

@prashanthr6383 prashanthr6383 merged commit 1b0b0c0 into main Jan 15, 2025
11 checks passed
@prashanthr6383 prashanthr6383 deleted the 2789-table-context-menu-only-row-actions branch January 15, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modus-table Modus Table component development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Context Menu-Only Row Actions
3 participants