Slider: fix modus slider selection #3026
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
SuruthiShriP
force-pushed
the
issue-2717/fix-slider-selection
branch
from
5f3dfaf to
d23f7ba
Compare
This comment was marked as resolved.
This comment was marked as resolved.
coliff
force-pushed
the
issue-2717/fix-slider-selection
branch
from
d23f7ba to
a345d9b
Compare
jewel-shajan
requested changes
Nov 26, 2024
|
Yes, the disabled state should be gray. The slider design in this PR is good, an improvement, but it's actually different to what appears on the Figma file (which doesn't have a different color for the selected range). We need input from: @enowak1031 and @mitch-trimble if we can proceed with this.
|
|
|
…SuruthiShriP/modus-web-components into issue-2717/fix-slider-selection
jewel-shajan
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no difference in the visibility of selected and non selected part of the slider as
the entire part is shown in blue color.
https://deploy-preview-3026--moduswebcomponents.netlify.app/?path=/story/components-slider--default
References #2717