AutoComplete: Delete chips using delete key
#3127
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for moduswebcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
coliff
changed the title
delete key
…p-using-tab-and-delete
| @@ -364,7 +364,18 @@ export class ModusAutocomplete { | |||
| this.valueChange.emit(search); | |||
| }; | |||
|
|
|||
| handleChipDelete = (e,chip) => { | |||
| if(e.key !="Delete") { | |||
There was a problem hiding this comment.
is the linter not throwing an error for missing space after the != ?
There was a problem hiding this comment.
linter does it for css files, modified it
| @@ -364,7 +364,18 @@ export class ModusAutocomplete { | |||
| this.valueChange.emit(search); | |||
| }; | |||
|
|
|||
| handleChipDelete = (e,chip) => { | |||
| if(e.key !="Delete") { | |||
There was a problem hiding this comment.
Its always safe to go with !== to validate the type as well.
There was a problem hiding this comment.
Modified it, since e.key is the left operator and a keyboard input , i thought its always going to return the same time as the right operator is hardcoded
…-and-delete' of https://github.com/trimble-oss/modus-web-components into 3108-autocomplete-allow-user-to-delete-a-chip-using-tab-and-delete
…p-using-tab-and-delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Fixes AutoComplete: Allow user to delete a chip using tab and delete #3108
Type of change
How Has This Been Tested?
Checklist