-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contribution-process.md #743
base: main
Are you sure you want to change the base?
Conversation
Workshop additions and checkbox tables.
Engineering checklist modified.
Reorganized cards on page.
|
||
Upon submission, a Clickup issue is automatically created in the "Submitted" column on the MoAB Board. MoAB meets weekly for reviews and handles incoming submissions. Please, allow five (5) business days for your submission to be reviewed. The submitting party is notified by the MoAB lead once their submission is reviewed. | ||
|
||
#### 2.2. Engineering Submission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly hold on with the Engineering Submission section, I would like @coliff to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is work in progress, no worries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soniakaukonen I would recommend adding a link to https://github.com/trimble-oss/modus-web-components/blob/main/CONTRIBUTING.md for more details on the contributing guidelines for web components.
@coliff Can we include Modus Bootstrap guidelines too ?
The Modus contribution process is led by the Modus Approval Board (MoAB). | ||
|
||
The Modus Approval Board (MoAB) is a cross-organizational team consisting of Senior UX Designers representing a variety of Trimble products in addition to the Modus Delivery Team. MoAB is focused on maintaining, organizing, reviewing, and pushing along component and pattern submissions to Trimble's Modus Design System leading the contribution process. | ||
|
||
{{< img src="/img/guide/contribution-process.svg" dark="/img/guide/contribution-process-dark.svg" width="854" height="392" alt="Contribution Process" loading="auto" >}} | ||
|
||
### 1. Understanding the design system and the process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a flowchart or a pictorial representation of the process would be really useful. Sometimes people don't spend even 2 mins for reading. I hope we can consider this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msankaran0712 This was planned but we have a resourcing issue to solve.
✅ Deploy Preview for modus-styleguide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@enowak1031 - what shall we do with this PR? |
Workshop additions and checkbox tables.
https://deploy-preview-743--modus-styleguide.netlify.app/