ci: Stabilize L0_pinned_memory flakiness #7929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_pinned_memory test more consistent
indrajit96
previously approved these changes
Jan 13, 2025
|
Jobs passing on multiple re-runs. Made a small change to request count number to reduce test time a bit. Should be faster and pass more consistently now. |
yinggeh
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L0_pinned_memory fails intermittently due to PA unstable measurements that are not critical to the test functionality - this is not a performance test.
This PR adds the use of
--request-countin PA to remove PA stability criteria and make L0_pinned_memory test more consistentIn reality, we probably don't need to be using PA for this test, and can swap it out with a simpler client that doesn't measure performance.
For simplicity, we can just relax the stability requirements on PA to avoid this error with minimal changes for now.