Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Stabilize L0_perf_analyzer_capi test consistency #7946

Merged
merged 2 commits into from
Jan 16, 2025
Merged

test: Stabilize L0_perf_analyzer_capi test consistency #7946

merged 2 commits into from
Jan 16, 2025

Conversation

rmccorm4
Copy link
Contributor

@rmccorm4 rmccorm4 commented Jan 16, 2025 •
edited
Loading

  1. Add STABILITY_THRESHOLD consistently to all test cases - this isn't a performance test and shouldn't be failing on stability measurements.
  2. Remove negative test for using async mode with triton_c_api. It looks like async support for triton_c_api was added here with the addition of TRT-LLM engine in-process support. See screenshot below.

image

@rmccorm4
Add STABILITY_THRESHOLD consistently to all test cases - this isn't a…
66f11f7 
… performance test and shouldn't be failing on stability measurements
@rmccorm4
Remove negative test that asserts triton_c_api doesn't support async …
e3d785b 
…mode, because async support for triton_c_api was added in triton-inference-server/perf_analyzer#35
dyastremsky
dyastremsky approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@rmccorm4 rmccorm4 merged commit f7fe649 into main Jan 16, 2025
3 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick/L0_perf_analyzer_capi branch January 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyastremsky dyastremsky dyastremsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmccorm4 @dyastremsky